Commit a83bfdca authored by Sukrut Bellary's avatar Sukrut Bellary Committed by Chanwoo Choi
Browse files

PM / devfreq: mtk-cci: Fix variable deferencing before NULL check 



smatch warning:
drivers/devfreq/mtk-cci-devfreq.c:135 mtk_ccifreq_target()
warn: variable dereferenced before check 'drv' (see line 130)

This is based on static analysis only. Compilation tested.

Signed-off-by: default avatarSukrut Bellary <sukrut.bellary@linux.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent ccb69e22

drivers/devfreq/mtk-cci-devfreq.c

+2 −1
Original line number Diff line number Diff line
@@ -127,7 +127,7 @@ static int mtk_ccifreq_target(struct device *dev, unsigned long *freq, 
			      u32 flags)

{

	struct mtk_ccifreq_drv *drv = dev_get_drvdata(dev);

	struct clk *cci_pll = clk_get_parent(drv->cci_clk);

	struct clk *cci_pll;

	struct dev_pm_opp *opp;

	unsigned long opp_rate;

	int voltage, pre_voltage, inter_voltage, target_voltage, ret;
@@ -139,6 +139,7 @@ static int mtk_ccifreq_target(struct device *dev, unsigned long *freq, 
		return 0;



	inter_voltage = drv->inter_voltage;

	cci_pll = clk_get_parent(drv->cci_clk);



	opp_rate = *freq;

	opp = devfreq_recommended_opp(dev, &opp_rate, 1);