Commit a82c7abd authored by Minas Harutyunyan's avatar Minas Harutyunyan Committed by Felipe Balbi
Browse files

usb: dwc2: hcd: Fix host channel halt flow 



According databook in Buffer and External DMA mode
non-split periodic channels can't be halted.

Acked-by: default avatarJohn Youn <johnyoun@synopsys.com>
Signed-off-by: default avatarMinas Harutyunyan <hminas@synopsys.com>
Signed-off-by: default avatarGrigor Tovmasyan <tovmasya@synopsys.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 9d729a7a

drivers/usb/dwc2/hcd.c

+18 −0
Original line number Diff line number Diff line
@@ -977,6 +977,24 @@ void dwc2_hc_halt(struct dwc2_hsotg *hsotg, struct dwc2_host_chan *chan, 


	if (dbg_hc(chan))

		dev_vdbg(hsotg->dev, "%s()\n", __func__);



	/*

	 * In buffer DMA or external DMA mode channel can't be halted

	 * for non-split periodic channels. At the end of the next

	 * uframe/frame (in the worst case), the core generates a channel

	 * halted and disables the channel automatically.

	 */

	if ((hsotg->params.g_dma && !hsotg->params.g_dma_desc) ||

	    hsotg->hw_params.arch == GHWCFG2_EXT_DMA_ARCH) {

		if (!chan->do_split &&

		    (chan->ep_type == USB_ENDPOINT_XFER_ISOC ||

		     chan->ep_type == USB_ENDPOINT_XFER_INT)) {

			dev_err(hsotg->dev, "%s() Channel can't be halted\n",

				__func__);

			return;

		}

	}



	if (halt_status == DWC2_HC_XFER_NO_HALT_STATUS)

		dev_err(hsotg->dev, "!!! halt_status = %d !!!\n", halt_status);