Commit a81561c6 authored by kernel test robot's avatar kernel test robot Committed by Yongqiang Liu
Browse files

of: overlay: fix for_each_child.cocci warnings 

mainline inclusion
from mainline-v5.13-rc1
commit c4d74f0f
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I73DDA
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c4d74f0f978ed5ceee62cd3f6708081042e582a1



------------------------------------------------

Function "for_each_child_of_node" should have of_node_put() before goto.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: 82c2d813 ("coccinelle: iterators: Add for_each_child.cocci script")
CC: Sumera Priyadarsini <sylphrenadin@gmail.com>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarJulia Lawall <julia.lawall@inria.fr>
Reviewed-by: default avatarFrank Rowand <frank.rowand@sony.com>
Tested-by: default avatarFrank Rowand <frank.rowand@sony.com>
Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2103221918450.2918@hadrien


Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarZhang Zekun <zhangzekun11@huawei.com>
Reviewed-by: default avatarxuqiang <xuqiang36@huawei.com>
Reviewed-by: default avatarWeilong Chen <chenweilong@huawei.com>
Signed-off-by: default avatarYongqiang Liu <liuyongqiang13@huawei.com>
parent 26e94eaf

drivers/of/overlay.c

+1 −0
Original line number Diff line number Diff line
@@ -713,6 +713,7 @@ static int init_overlay_changeset(struct overlay_changeset *ovcs, 
		if (!fragment->target) {

			of_node_put(fragment->overlay);

			ret = -EINVAL;

			of_node_put(node);

			goto err_free_fragments;

		}