Commit a80ceed6 authored by Josh Poimboeuf's avatar Josh Poimboeuf
Browse files

mips/cpu: Make sure play_dead() doesn't return 



play_dead() doesn't return.  Make that more explicit with a BUG().

BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.

Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
Link: https://lore.kernel.org/r/b195e4da190bb06b7d4af15d66ce6129e2347630.1676358308.git.jpoimboe@kernel.org


Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@kernel.org>
parent 142dbcf3

arch/mips/kernel/smp-bmips.c

+2 −0
Original line number Diff line number Diff line
@@ -415,6 +415,8 @@ void __ref play_dead(void) 
	"	wait\n"

	"	j	bmips_secondary_reentry\n"

	: : : "memory");



	BUG();

}



#endif /* CONFIG_HOTPLUG_CPU */

arch/mips/loongson64/smp.c

+1 −0
Original line number Diff line number Diff line
@@ -823,6 +823,7 @@ void play_dead(void) 
	state_addr = &per_cpu(cpu_state, cpu);

	mb();

	play_dead_at_ckseg1(state_addr);

	BUG();

}



static int loongson3_disable_clock(unsigned int cpu)