Commit a7db5ed8 authored by Kurt Kanzenbach's avatar Kurt Kanzenbach Committed by David S. Miller
Browse files

net: dsa: hellcreek: Fix incorrect setting of GCL 



Currently the gate control list which is programmed into the hardware is
incorrect resulting in wrong traffic schedules. The problem is the loop
variables are incremented before they are referenced. Therefore, move the
increment to the end of the loop.

Fixes: 24dfc6eb ("net: dsa: hellcreek: Add TAPRIO offloading support")
Signed-off-by: default avatarKurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 43fed4d4

drivers/net/dsa/hirschmann/hellcreek.c

+3 −3
Original line number Diff line number Diff line
@@ -1472,9 +1472,6 @@ static void hellcreek_setup_gcl(struct hellcreek *hellcreek, int port, 
		u16 data;

		u8 gates;



		cur++;

		next++;



		if (i == schedule->num_entries)

			gates = initial->gate_mask ^

				cur->gate_mask;
@@ -1503,6 +1500,9 @@ static void hellcreek_setup_gcl(struct hellcreek *hellcreek, int port, 
			(initial->gate_mask <<

			 TR_GCLCMD_INIT_GATE_STATES_SHIFT);

		hellcreek_write(hellcreek, data, TR_GCLCMD);



		cur++;

		next++;

	}

}