Commit a78418e6 authored by Jan Kara's avatar Jan Kara Committed by Jens Axboe
Browse files

block: Always initialize bio IO priority on submit 



Currently, IO priority set in task's IO context is not reflected in the
bio->bi_ioprio for most IO (only io_uring and direct IO set it). This
results in odd results where process is submitting some bios with one
priority and other bios with a different (unset) priority and due to
differing priorities bios cannot be merged. Make sure bio->bi_ioprio is
always set on bio submission.

Reviewed-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Tested-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220623074840.5960-9-jack@suse.cz


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9c6227e0

block/blk-mq.c

+3 −0
Original line number Diff line number Diff line
@@ -2782,6 +2782,9 @@ static inline struct request *blk_mq_get_cached_request(struct request_queue *q, 


static void bio_set_ioprio(struct bio *bio)

{

	/* Nobody set ioprio so far? Initialize it based on task's nice value */

	if (IOPRIO_PRIO_CLASS(bio->bi_ioprio) == IOPRIO_CLASS_NONE)

		bio->bi_ioprio = get_current_ioprio();

	blkcg_set_ioprio(bio);

}