Unverified Commit a7609858 authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/vc4: hvs: Remove dlist setup duplication 



Setting the DISPLISTx register needs to occur in every case, and we
don't need to protect the register using the event_lock, so we can just
move it after the if branches and simplify a bit the function.

Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Acked-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220331143744.777652-5-maxime@cerno.tech
parent e418639d

drivers/gpu/drm/vc4/vc4_hvs.c

+3 −6
Original line number Diff line number Diff line
@@ -402,14 +402,11 @@ static void vc4_hvs_update_dlist(struct drm_crtc *crtc) 
			crtc->state->event = NULL;

		}



		HVS_WRITE(SCALER_DISPLISTX(vc4_state->assigned_channel),

			  vc4_state->mm.start);



		spin_unlock_irqrestore(&dev->event_lock, flags);

	} else {

	}



	HVS_WRITE(SCALER_DISPLISTX(vc4_state->assigned_channel),

		  vc4_state->mm.start);

	}



	spin_lock_irqsave(&vc4_crtc->irq_lock, flags);

	vc4_crtc->current_dlist = vc4_state->mm.start;