Commit a75badeb authored by Dan Carpenter's avatar Dan Carpenter Committed by Jason Gunthorpe
Browse files

RDMA/siw: Fix refcounting leak in siw_create_qp() 

The atomic_inc() needs to be paired with an atomic_dec() on the error
path.

Fixes: 514aee66 ("RDMA: Globally allocate and release QP memory")
Link: https://lore.kernel.org/r/20220118091104.GA11671@kili


Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Reviewed-by: default avatarBernard Metzler <bmt@zurich.ibm.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 36e8169e

drivers/infiniband/sw/siw/siw_verbs.c

+2 −1
Original line number Diff line number Diff line
@@ -313,7 +313,8 @@ int siw_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *attrs, 


	if (atomic_inc_return(&sdev->num_qp) > SIW_MAX_QP) {

		siw_dbg(base_dev, "too many QP's\n");

		return -ENOMEM;

		rv = -ENOMEM;

		goto err_atomic;

	}

	if (attrs->qp_type != IB_QPT_RC) {

		siw_dbg(base_dev, "only RC QP's supported\n");