Commit a74e7263 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

greybus: svc: clean up link configuration hack at hello 



Commit ee2f2074 ("greybus: svc: reconfig APBridgeA-Switch link to
handle required load") added a temporary hack which reconfigures the
link at HELLO by abusing the deferred request processing mechanism.

Restructure the HELLO request processing so that the link-configuration
work is queued before creating the debugfs files and add a comment
explaining why it's there.

Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20220202113347.1288-4-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5f648e00

drivers/greybus/svc.c

+8 −5
Original line number Diff line number Diff line
@@ -864,16 +864,19 @@ static int gb_svc_hello(struct gb_operation *op) 
		goto err_deregister_svc;

	}



	gb_svc_debugfs_init(svc);



	/*

	 * FIXME: This is a temporary hack to reconfigure the link at HELLO

	 * (which abuses the deferred request processing mechanism).

	 */

	ret = gb_svc_queue_deferred_request(op);

	if (ret)

		goto err_remove_debugfs;

		goto err_destroy_watchdog;



	gb_svc_debugfs_init(svc);



	return 0;



err_remove_debugfs:

	gb_svc_debugfs_exit(svc);

err_destroy_watchdog:

	gb_svc_watchdog_destroy(svc);

err_deregister_svc:

	device_del(&svc->dev);