Commit a72afd87 authored by Will Deacon's avatar Will Deacon Committed by Peter Zijlstra
Browse files

tlb: mmu_gather: Remove start/end arguments from tlb_gather_mmu() 



The 'start' and 'end' arguments to tlb_gather_mmu() are no longer
needed now that there is a separate function for 'fullmm' flushing.

Remove the unused arguments and update all callers.

Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarWill Deacon <will@kernel.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarYu Zhao <yuzhao@google.com>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/CAHk-=wjQWa14_4UpfDf=fiineNP+RH74kZeDMo_f1D35xNzq9w@mail.gmail.com
parent d8b45053

arch/ia64/include/asm/tlb.h

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ 
 * unmapping a portion of the virtual address space, these hooks are called according to

 * the following template:

 *

 *	tlb <- tlb_gather_mmu(mm, start, end);		// start unmap for address space MM

 *	tlb <- tlb_gather_mmu(mm);			// start unmap for address space MM

 *	{

 *	  for each vma that needs a shootdown do {

 *	    tlb_start_vma(tlb, vma);

arch/x86/kernel/ldt.c

+1 −1
Original line number Diff line number Diff line
@@ -398,7 +398,7 @@ static void free_ldt_pgtables(struct mm_struct *mm) 
	if (!boot_cpu_has(X86_FEATURE_PTI))

		return;



	tlb_gather_mmu(&tlb, mm, start, end);

	tlb_gather_mmu(&tlb, mm);

	free_pgd_range(&tlb, start, end, start, end);

	tlb_finish_mmu(&tlb);

#endif

fs/exec.c

+1 −1
Original line number Diff line number Diff line
@@ -708,7 +708,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, unsigned long shift) 
		return -ENOMEM;



	lru_add_drain();

	tlb_gather_mmu(&tlb, mm, old_start, old_end);

	tlb_gather_mmu(&tlb, mm);

	if (new_end > old_start) {

		/*

		 * when the old and new regions overlap clear from new_end.

include/linux/mm_types.h

+1 −2
Original line number Diff line number Diff line
@@ -588,8 +588,7 @@ static inline cpumask_t *mm_cpumask(struct mm_struct *mm) 
}



struct mmu_gather;

extern void tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm,

				unsigned long start, unsigned long end);

extern void tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm);

extern void tlb_gather_mmu_fullmm(struct mmu_gather *tlb, struct mm_struct *mm);

extern void tlb_finish_mmu(struct mmu_gather *tlb);

mm/hugetlb.c

+1 −15
Original line number Diff line number Diff line
@@ -3967,23 +3967,9 @@ void __unmap_hugepage_range_final(struct mmu_gather *tlb, 
void unmap_hugepage_range(struct vm_area_struct *vma, unsigned long start,

			  unsigned long end, struct page *ref_page)

{

	struct mm_struct *mm;

	struct mmu_gather tlb;

	unsigned long tlb_start = start;

	unsigned long tlb_end = end;



	/*

	 * If shared PMDs were possibly used within this vma range, adjust

	 * start/end for worst case tlb flushing.

	 * Note that we can not be sure if PMDs are shared until we try to

	 * unmap pages.  However, we want to make sure TLB flushing covers

	 * the largest possible range.

	 */

	adjust_range_if_pmd_sharing_possible(vma, &tlb_start, &tlb_end);



	mm = vma->vm_mm;



	tlb_gather_mmu(&tlb, mm, tlb_start, tlb_end);

	tlb_gather_mmu(&tlb, vma->vm_mm);

	__unmap_hugepage_range(&tlb, vma, start, end, ref_page);

	tlb_finish_mmu(&tlb);

}