Commit a6f8e68e authored May 16, 2021 by Christophe JAILLET Committed by Herbert Xu May 23, 2021

crypto: ccp - Fix a resource leak in an error handling path



If an error occurs after calling 'sp_get_irqs()', 'sp_free_irqs()' must be
called as already done in the error handling path.

Fixes: f4d18d65 ("crypto: ccp - Abstract interrupt registeration")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: John Allen <john.allen@amd.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent b7da13d0

drivers/crypto/ccp/sp-pci.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -222,7 +222,7 @@ static int sp_pci_probe(struct pci_dev pdev, const struct pci_device_id id)
		if (ret) {
		dev_err(dev, "dma_set_mask_and_coherent failed (%d)\n",
		ret);
		goto e_err;
		goto free_irqs;
		}
		}

		@@ -230,10 +230,12 @@ static int sp_pci_probe(struct pci_dev pdev, const struct pci_device_id id)

		ret = sp_init(sp);
		if (ret)
		goto e_err;
		goto free_irqs;

		return 0;

		free_irqs:
		sp_free_irqs(sp);
		e_err:
		dev_notice(dev, "initialization failed\n");
		return ret;