Commit a6df0674 authored by Jörn-Thorben Hinz's avatar Jörn-Thorben Hinz Committed by Andrii Nakryiko
Browse files

bpftool: Don't try to return value from void function in skeleton 



A skeleton generated by bpftool previously contained a return followed
by an expression in OBJ_NAME__detach(), which has return type void. This
did not hurt, the bpf_object__detach_skeleton() called there returns
void itself anyway, but led to a warning when compiling with e.g.
-pedantic.

Signed-off-by: default avatarJörn-Thorben Hinz <jthinz@mailbox.tu-berlin.de>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Reviewed-by: default avatarQuentin Monnet <quentin@isovalent.com>
Link: https://lore.kernel.org/bpf/20220726133203.514087-1-jthinz@mailbox.tu-berlin.de
parent 5eff8c18

tools/bpf/bpftool/gen.c

+1 −1
Original line number Diff line number Diff line
@@ -1175,7 +1175,7 @@ static int do_skeleton(int argc, char **argv) 
		static inline void					    \n\

		%1$s__detach(struct %1$s *obj)				    \n\

		{							    \n\

			return bpf_object__detach_skeleton(obj->skeleton);  \n\

			bpf_object__detach_skeleton(obj->skeleton);	    \n\

		}							    \n\

		",

		obj_name