Commit a6d6f4f1 authored Apr 30, 2019 by Parav Pandit Committed by Alex Williamson May 07, 2019

vfio/mdev: Follow correct remove sequence



mdev_remove_sysfs_files() should follow exact mirror sequence of a
create, similar to what is followed in error unwinding path of
mdev_create_sysfs_files().

Fixes: 6a62c1df ("vfio/mdev: Re-order sysfs attribute creation")
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Signed-off-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

parent d3000463

drivers/vfio/mdev/mdev_sysfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -280,7 +280,7 @@ int mdev_create_sysfs_files(struct device dev, struct mdev_type type)

		void mdev_remove_sysfs_files(struct device dev, struct mdev_type type)
		{
		sysfs_remove_files(&dev->kobj, mdev_device_attrs);
		sysfs_remove_link(&dev->kobj, "mdev_type");
		sysfs_remove_link(type->devices_kobj, dev_name(dev));
		sysfs_remove_files(&dev->kobj, mdev_device_attrs);
		}