Commit a6c9e387 authored by Rob Herring's avatar Rob Herring Committed by Joerg Roedel
Browse files

iommu: Use of_property_present() for testing DT property presence 



It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarRobin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/20230310144709.1542910-1-robh@kernel.org


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent 1b0b5f50

drivers/iommu/arm/arm-smmu/arm-smmu.c

+1 −1
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ static int arm_smmu_register_legacy_master(struct device *dev, 
	int err;



	np = dev_get_dev_node(dev);

	if (!np || !of_find_property(np, "#stream-id-cells", NULL)) {

	if (!np || !of_property_present(np, "#stream-id-cells")) {

		of_node_put(np);

		return -ENODEV;

	}

drivers/iommu/ipmmu-vmsa.c

+1 −1
Original line number Diff line number Diff line
@@ -1014,7 +1014,7 @@ static int ipmmu_probe(struct platform_device *pdev) 
	 * the lack of has_cache_leaf_nodes flag or renesas,ipmmu-main property.

	 */

	if (!mmu->features->has_cache_leaf_nodes ||

	    !of_find_property(pdev->dev.of_node, "renesas,ipmmu-main", NULL))

	    !of_property_present(pdev->dev.of_node, "renesas,ipmmu-main"))

		mmu->root = mmu;

	else

		mmu->root = ipmmu_find_root();