Commit a692fc39 authored Nov 25, 2021 by Andy Shevchenko Committed by Greg Kroah-Hartman Dec 03, 2021

misc: at25: Don't copy garbage to the at25->chip in FRAM case



Even if we know that we are going to fill everything later on
it's bad style and fragile to copy garbage from the stack to
the data structure that will be used in the driver.

Fixes: fd307a4a ("nvmem: prepare basics for FRAM support")
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211125212729.86585-3-andriy.shevchenko@linux.intel.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 5b557298

drivers/misc/eeprom/at25.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -390,7 +390,10 @@ static int at25_probe(struct spi_device *spi)

		/* Chip description */
		if (!spi->dev.platform_data) {
		if (!is_fram) {
		if (is_fram) {
		/* We file fields for FRAM case later on */
		memset(&chip, 0, sizeof(chip));
		} else {
		err = at25_fw_to_chip(&spi->dev, &chip);
		if (err)
		return err;