Commit a650628b authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe
Browse files

block: move submit_bio_checks() into submit_bio_noacct 



It is more clean & readable to check bio when starting to submit it,
instead of just before calling ->submit_bio() or blk_mq_submit_bio().

Also it provides us chance to optimize bio submission without checking
bio.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20220216044514.2903784-2-ming.lei@redhat.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9f9adea7

block/blk-core.c

+3 −3
Original line number Diff line number Diff line
@@ -797,9 +797,6 @@ static void __submit_bio(struct bio *bio) 
{

	struct gendisk *disk = bio->bi_bdev->bd_disk;



	if (unlikely(!submit_bio_checks(bio)))

		return;



	if (!disk->fops->submit_bio)

		blk_mq_submit_bio(bio);

	else
@@ -893,6 +890,9 @@ static void __submit_bio_noacct_mq(struct bio *bio) 
 */

void submit_bio_noacct(struct bio *bio)

{

	if (unlikely(!submit_bio_checks(bio)))

		return;



	/*

	 * We only want one ->submit_bio to be active at a time, else stack

	 * usage with stacked devices could be a problem.  Use current->bio_list