Commit a627f28c authored by Suraj Sonawane's avatar Suraj Sonawane Committed by Zheng Qixing
Browse files

scsi: sg: Fix slab-use-after-free read in sg_release() 

stable inclusion
from stable-v6.6.66
commit 59b30afa578637169e2819536bb66459fdddc39d
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/IBEAN7
CVE: CVE-2024-56631

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=59b30afa578637169e2819536bb66459fdddc39d



--------------------------------

[ Upstream commit f10593ad9bc36921f623361c9e3dd96bd52d85ee ]

Fix a use-after-free bug in sg_release(), detected by syzbot with KASAN:

BUG: KASAN: slab-use-after-free in lock_release+0x151/0xa30
kernel/locking/lockdep.c:5838
__mutex_unlock_slowpath+0xe2/0x750 kernel/locking/mutex.c:912
sg_release+0x1f4/0x2e0 drivers/scsi/sg.c:407

In sg_release(), the function kref_put(&sfp->f_ref, sg_remove_sfp) is
called before releasing the open_rel_lock mutex. The kref_put() call may
decrement the reference count of sfp to zero, triggering its cleanup
through sg_remove_sfp(). This cleanup includes scheduling deferred work
via sg_remove_sfp_usercontext(), which ultimately frees sfp.

After kref_put(), sg_release() continues to unlock open_rel_lock and may
reference sfp or sdp. If sfp has already been freed, this results in a
slab-use-after-free error.

Move the kref_put(&sfp->f_ref, sg_remove_sfp) call after unlocking the
open_rel_lock mutex. This ensures:

 - No references to sfp or sdp occur after the reference count is
   decremented.

 - Cleanup functions such as sg_remove_sfp() and
   sg_remove_sfp_usercontext() can safely execute without impacting the
   mutex handling in sg_release().

The fix has been tested and validated by syzbot. This patch closes the
bug reported at the following syzkaller link and ensures proper
sequencing of resource cleanup and mutex operations, eliminating the
risk of use-after-free errors in sg_release().

Reported-by: default avatar <syzbot+7efb5850a17ba6ce098b@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=7efb5850a17ba6ce098b


Tested-by: default avatar <syzbot+7efb5850a17ba6ce098b@syzkaller.appspotmail.com>
Fixes: cc833acb ("sg: O_EXCL and other lock handling")
Signed-off-by: default avatarSuraj Sonawane <surajsonawane0215@gmail.com>
Link: https://lore.kernel.org/r/20241120125944.88095-1-surajsonawane0215@gmail.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>

Conflicts:
	drivers/scsi/sg.c
[Context conflicts.]
Signed-off-by: default avatarZheng Qixing <zhengqixing@huawei.com>
parent 604e996d

drivers/scsi/sg.c

+1 −1
Original line number Diff line number Diff line
@@ -393,7 +393,6 @@ sg_release(struct inode *inode, struct file *filp) 


	mutex_lock(&sdp->open_rel_lock);

	scsi_autopm_put_device(sdp->device);

	kref_put(&sfp->f_ref, sg_remove_sfp);

	sdp->open_cnt--;



	/* possibly many open()s waiting on exlude clearing, start many;
@@ -405,6 +404,7 @@ sg_release(struct inode *inode, struct file *filp) 
		wake_up_interruptible(&sdp->open_wait);

	}

	mutex_unlock(&sdp->open_rel_lock);

	kref_put(&sfp->f_ref, sg_remove_sfp);

	return 0;

}