Commit a5dba0f2 authored by Luiz Angelo Daros de Luca's avatar Luiz Angelo Daros de Luca Committed by David S. Miller
Browse files

net: dsa: rtl8365mb: add GMII as user port mode 



Recent net-next fails to initialize ports with:

 realtek-smi switch: phy mode gmii is unsupported on port 0
 realtek-smi switch lan5 (uninitialized): validation of gmii with
 support 0000000,00000000,000062ef and advertisement
 0000000,00000000,000062ef failed: -22
 realtek-smi switch lan5 (uninitialized): failed to connect to PHY:
 -EINVAL
 realtek-smi switch lan5 (uninitialized): error -22 setting up PHY
 for tree 1, switch 0, port 0

Current net branch(3dd7d40b) is not
affected.

I also noticed the same issue before with older versions but using
a MDIO interface driver, not realtek-smi.

Tested-by: default avatarArınç ÜNAL <arinc.unal@arinc9.com>
Signed-off-by: default avatarLuiz Angelo Daros de Luca <luizluca@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e85fbf53

drivers/net/dsa/rtl8365mb.c

+2 −1
Original line number Diff line number Diff line
@@ -900,7 +900,8 @@ static bool rtl8365mb_phy_mode_supported(struct dsa_switch *ds, int port, 
{

	if (dsa_is_user_port(ds, port) &&

	    (interface == PHY_INTERFACE_MODE_NA ||

	     interface == PHY_INTERFACE_MODE_INTERNAL))

	     interface == PHY_INTERFACE_MODE_INTERNAL ||

	     interface == PHY_INTERFACE_MODE_GMII))

		/* Internal PHY */

		return true;

	else if (dsa_is_cpu_port(ds, port) &&