Commit a5c5d8d5 authored by Lang Yu's avatar Lang Yu Committed by Alex Deucher
Browse files

drm/amdgpu: fix a potential memory leak in amdgpu_device_fini_sw() 



amdgpu_fence_driver_sw_fini() should be executed before
amdgpu_device_ip_fini(), otherwise fence driver resource
won't be properly freed as adev->rings have been tore down.

Fixes: 72c8c97b ("drm/amdgpu: Split amdgpu_device_fini into early and late")

Signed-off-by: default avatarLang Yu <lang.yu@amd.com>
Reviewed-by: default avatarAndrey Grodzovsky <andrey.grodzovsky@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 68df0f19

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

+1 −1
Original line number Diff line number Diff line
@@ -3852,8 +3852,8 @@ void amdgpu_device_fini_hw(struct amdgpu_device *adev) 


void amdgpu_device_fini_sw(struct amdgpu_device *adev)

{

	amdgpu_device_ip_fini(adev);

	amdgpu_fence_driver_sw_fini(adev);

	amdgpu_device_ip_fini(adev);

	release_firmware(adev->firmware.gpu_info_fw);

	adev->firmware.gpu_info_fw = NULL;

	adev->accel_working = false;