Commit a5ac0fd1 authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini
Browse files

KVM: selftests: Remove perf_test_args.host_page_size 



Remove perf_test_args.host_page_size and instead use getpagesize() so
that it's somewhat obvious that, for tests that care about the host page
size, they care about the system page size, not the hardware page size,
e.g. that the logic is unchanged if hugepages are in play.

No functional change intended.

Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Reviewed-by: default avatarBen Gardon <bgardon@google.com>
Signed-off-by: default avatarDavid Matlack <dmatlack@google.com>
Message-Id: <20211111000310.1435032-10-dmatlack@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent b91b637f

tools/testing/selftests/kvm/include/perf_test_util.h

+0 −1
Original line number Diff line number Diff line
@@ -28,7 +28,6 @@ struct perf_test_vcpu_args { 


struct perf_test_args {

	struct kvm_vm *vm;

	uint64_t host_page_size;

	uint64_t gpa;

	uint64_t guest_page_size;

	int wr_fract;

tools/testing/selftests/kvm/lib/perf_test_util.c

+1 −2
Original line number Diff line number Diff line
@@ -60,7 +60,6 @@ struct kvm_vm *perf_test_create_vm(enum vm_guest_mode mode, int vcpus, 


	pr_info("Testing guest mode: %s\n", vm_guest_mode_string(mode));



	pta->host_page_size = getpagesize();

	/*

	 * Snapshot the non-huge page size.  This is used by the guest code to

	 * access/dirty pages at the logging granularity.
@@ -70,7 +69,7 @@ struct kvm_vm *perf_test_create_vm(enum vm_guest_mode mode, int vcpus, 
	guest_num_pages = vm_adjust_num_guest_pages(mode,

				(vcpus * vcpu_memory_bytes) / pta->guest_page_size);



	TEST_ASSERT(vcpu_memory_bytes % pta->host_page_size == 0,

	TEST_ASSERT(vcpu_memory_bytes % getpagesize() == 0,

		    "Guest memory size is not host page size aligned.");

	TEST_ASSERT(vcpu_memory_bytes % pta->guest_page_size == 0,

		    "Guest memory size is not guest page size aligned.");