Unverified Commit a5872bd3 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

regulator: s5m8767: Drop regulators OF node reference 



The device node reference obtained with of_get_child_by_name() should be
dropped on error paths.

Fixes: 26aec009 ("regulator: add device tree support for s5m8767")
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20210121155914.48034-1-krzk@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e46c52f7

drivers/regulator/s5m8767.c

+6 −2
Original line number Diff line number Diff line
@@ -544,14 +544,18 @@ static int s5m8767_pmic_dt_parse_pdata(struct platform_device *pdev, 
	rdata = devm_kcalloc(&pdev->dev,

			     pdata->num_regulators, sizeof(*rdata),

			     GFP_KERNEL);

	if (!rdata)

	if (!rdata) {

		of_node_put(regulators_np);

		return -ENOMEM;

	}



	rmode = devm_kcalloc(&pdev->dev,

			     pdata->num_regulators, sizeof(*rmode),

			     GFP_KERNEL);

	if (!rmode)

	if (!rmode) {

		of_node_put(regulators_np);

		return -ENOMEM;

	}



	pdata->regulators = rdata;

	pdata->opmode = rmode;