Commit a5402cdc authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: ufs: Fix unsigned int compared with less than zero 

Variable 'tag' is currently an unsigned int and is being compared to less
than zero, this check is always false. Fix this by making 'tag' an int.

Link: https://lore.kernel.org/r/20210806144301.19864-1-colin.king@canonical.com


Fixes: 4728ab4a ("scsi: ufs: Remove ufshcd_valid_tag()")
Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Addresses-Coverity: ("Macro compares unsigned to 0")
parent 4758fd91

drivers/scsi/ufs/ufshcd.c

+1 −1
Original line number Diff line number Diff line
@@ -6974,7 +6974,7 @@ static int ufshcd_abort(struct scsi_cmnd *cmd) 
{

	struct Scsi_Host *host = cmd->device->host;

	struct ufs_hba *hba = shost_priv(host);

	unsigned int tag = cmd->request->tag;

	int tag = cmd->request->tag;

	struct ufshcd_lrb *lrbp = &hba->lrb[tag];

	unsigned long flags;

	int err = FAILED;