Unverified Commit a5201d42 authored by Schspa Shi's avatar Schspa Shi Committed by Mark Brown
Browse files

regmap: cache: Add extra parameter check in regcache_init 



When num_reg_defaults > 0 but reg_defaults is NULL, there will be a
NULL pointer exception.

Current code has no such usage, but as additional hardening, also
check this to prevent any chance of crashing.

Signed-off-by: default avatarSchspa Shi <schspa@gmail.com>
Link: https://lore.kernel.org/r/20220629130951.63040-1-schspa@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 06fae51b

drivers/base/regmap/regcache.c

+6 −0
Original line number Original line Diff line number Diff line
@@ -133,6 +133,12 @@ int regcache_init(struct regmap *map, const struct regmap_config *config) 
		return -EINVAL;

		return -EINVAL;

	}

	}





	if (config->num_reg_defaults && !config->reg_defaults) {

		dev_err(map->dev,

			"Register defaults number are set without the reg!\n");

		return -EINVAL;

	}



	for (i = 0; i < config->num_reg_defaults; i++)

	for (i = 0; i < config->num_reg_defaults; i++)

		if (config->reg_defaults[i].reg % map->reg_stride)

		if (config->reg_defaults[i].reg % map->reg_stride)

			return -EINVAL;

			return -EINVAL;