Commit a5053c92 authored by Maurizio Lombardi's avatar Maurizio Lombardi Committed by Christoph Hellwig
Browse files

nvme-tcp: fix memory leak when freeing a queue 



Release the page frag cache when tearing down the io queues

Signed-off-by: default avatarMaurizio Lombardi <mlombard@redhat.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarJohn Meneghini <jmeneghi@redhat.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 1d3ef9c3

drivers/nvme/host/tcp.c

+6 −0
Original line number Diff line number Diff line
@@ -1225,6 +1225,7 @@ static int nvme_tcp_alloc_async_req(struct nvme_tcp_ctrl *ctrl) 


static void nvme_tcp_free_queue(struct nvme_ctrl *nctrl, int qid)

{

	struct page *page;

	struct nvme_tcp_ctrl *ctrl = to_tcp_ctrl(nctrl);

	struct nvme_tcp_queue *queue = &ctrl->queues[qid];
@@ -1234,6 +1235,11 @@ static void nvme_tcp_free_queue(struct nvme_ctrl *nctrl, int qid) 
	if (queue->hdr_digest || queue->data_digest)

		nvme_tcp_free_crypto(queue);



	if (queue->pf_cache.va) {

		page = virt_to_head_page(queue->pf_cache.va);

		__page_frag_cache_drain(page, queue->pf_cache.pagecnt_bias);

		queue->pf_cache.va = NULL;

	}

	sock_release(queue->sock);

	kfree(queue->pdu);

	mutex_destroy(&queue->send_mutex);