Commit a4fe9b6d authored by Hao Chen's avatar Hao Chen Committed by David S. Miller
Browse files

net: hns3: fix access null pointer issue when set tx-buf-size as 0 



When set tx-buf-size as 0 by ethtool, hns3_init_tx_spare_buffer()
will return directly and priv->ring->tx_spare->len is uninitialized,
then print function access priv->ring->tx_spare->len will cause
this issue.

When set tx-buf-size as 0 by ethtool, the print function will
print 0 directly and not access priv->ring->tx_spare->len.

Fixes: 2373b35c ("net: hns3: add log for setting tx spare buf size")
Signed-off-by: default avatarHao Chen <chenhao288@hisilicon.com>
Signed-off-by: default avatarGuangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1728c056

drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c

+5 −2
Original line number Diff line number Diff line
@@ -1915,6 +1915,9 @@ static int hns3_set_tunable(struct net_device *netdev, 
			return ret;

		}



		if (!priv->ring->tx_spare)

			netdev_info(netdev, "the active tx spare buf size is 0, disable tx spare buffer\n");

		else

			netdev_info(netdev, "the active tx spare buf size is %u, due to page order\n",

				    priv->ring->tx_spare->len);