Commit a4f39c9f authored by Nicolas Dichtel's avatar Nicolas Dichtel Committed by David S. Miller
Browse files

net: handle ARPHRD_PPP in dev_is_mac_header_xmit() 



The goal is to support a bpf_redirect() from an ethernet device (ingress)
to a ppp device (egress).
The l2 header is added automatically by the ppp driver, thus the ethernet
header should be removed.

CC: stable@vger.kernel.org
Fixes: 27b29f63 ("bpf: add bpf_redirect() helper")
Signed-off-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
Tested-by: default avatarSiwar Zitouni <siwar.zitouni@6wind.com>
Reviewed-by: default avatarGuillaume Nault <gnault@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 84a58e60

include/linux/if_arp.h

+4 −0
Original line number Diff line number Diff line
@@ -53,6 +53,10 @@ static inline bool dev_is_mac_header_xmit(const struct net_device *dev) 
	case ARPHRD_NONE:

	case ARPHRD_RAWIP:

	case ARPHRD_PIMREG:

	/* PPP adds its l2 header automatically in ppp_start_xmit().

	 * This makes it look like an l3 device to __bpf_redirect() and tcf_mirred_init().

	 */

	case ARPHRD_PPP:

		return false;

	default:

		return true;