Unverified Commit a4e37950 authored by Sameer Pujar's avatar Sameer Pujar Committed by Mark Brown
Browse files

ASoC: tegra: Fix kcontrol put callback in AHUB 



The kcontrol put callback is expected to return 1 when there is change
in HW or when the update is acknowledged by driver. This would ensure
that change notifications are sent to subscribed applications. Update
the AHUB driver accordingly.

Fixes: 16e1bcc2 ("ASoC: tegra: Add Tegra210 based AHUB driver")
Signed-off-by: default avatarSameer Pujar <spujar@nvidia.com>
Suggested-by: default avatarJaroslav Kysela <perex@perex.cz>
Suggested-by: default avatarMark Brown <broonie@kernel.org>
Reviewed-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/1637219231-406-12-git-send-email-spujar@nvidia.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent d6202a57

sound/soc/tegra/tegra210_ahub.c

+7 −4
Original line number Diff line number Diff line
@@ -62,6 +62,7 @@ static int tegra_ahub_put_value_enum(struct snd_kcontrol *kctl, 
	unsigned int *item = uctl->value.enumerated.item;

	unsigned int value = e->values[item[0]];

	unsigned int i, bit_pos, reg_idx = 0, reg_val = 0;

	int change = 0;



	if (item[0] >= e->items)

		return -EINVAL;
@@ -86,12 +87,14 @@ static int tegra_ahub_put_value_enum(struct snd_kcontrol *kctl, 


		/* Update widget power if state has changed */

		if (snd_soc_component_test_bits(cmpnt, update[i].reg,

						update[i].mask, update[i].val))

			snd_soc_dapm_mux_update_power(dapm, kctl, item[0], e,

						update[i].mask,

						update[i].val))

			change |= snd_soc_dapm_mux_update_power(dapm, kctl,

								item[0], e,

								&update[i]);

	}



	return 0;

	return change;

}



static struct snd_soc_dai_driver tegra210_ahub_dais[] = {