Commit a4da4913 authored May 21, 2022 by Christophe JAILLET Committed by Tony Nguyen Jun 08, 2022

ice: Use correct order for the parameters of devm_kcalloc()

We should have 'n', then 'size', not the opposite.
This is harmless because the 2 values are just multiplied, but having
the correct order silence a (unpublished yet) smatch warning.

While at it use '*tun_seg' instead '*seg'. The both variable have the same
type, so the result is the same, but it lokks more logical.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

parent 0a3ca086

drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -852,7 +852,7 @@ ice_create_init_fdir_rule(struct ice_pf *pf, enum ice_fltr_ptype flow)
		if (!seg)
		return -ENOMEM;

		tun_seg = devm_kcalloc(dev, sizeof(*seg), ICE_FD_HW_SEG_MAX,
		tun_seg = devm_kcalloc(dev, ICE_FD_HW_SEG_MAX, sizeof(*tun_seg),
		GFP_KERNEL);
		if (!tun_seg) {
		devm_kfree(dev, seg);
		@@ -1214,7 +1214,7 @@ ice_cfg_fdir_xtrct_seq(struct ice_pf pf, struct ethtool_rx_flow_spec fsp,
		if (!seg)
		return -ENOMEM;

		tun_seg = devm_kcalloc(dev, sizeof(*seg), ICE_FD_HW_SEG_MAX,
		tun_seg = devm_kcalloc(dev, ICE_FD_HW_SEG_MAX, sizeof(*tun_seg),
		GFP_KERNEL);
		if (!tun_seg) {
		devm_kfree(dev, seg);