Unverified Commit a4d328ef authored by Charles Keepax's avatar Charles Keepax Committed by Mark Brown
Browse files

ASoC: wm_adsp: Update naming in error handling 



It seems the datasheet has never used the word slave for this error
status bit and has always used the term address error. So update the
driver to match the datasheets and also in the process align a bit
better with avoiding the use of such words where possible.

Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20200818160126.4852-1-ckeepax@opensource.cirrus.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 28f95795

sound/soc/codecs/wm_adsp.c

+4 −4
Original line number Diff line number Diff line
@@ -199,7 +199,7 @@ 
#define ADSP2_PMEM_ERR_ADDR_XMEM_ERR_ADDR    0x7C



#define ADSP2_REGION_LOCK_ERR_MASK           0x8000

#define ADSP2_SLAVE_ERR_MASK                 0x4000

#define ADSP2_ADDR_ERR_MASK                  0x4000

#define ADSP2_WDT_TIMEOUT_STS_MASK           0x2000

#define ADSP2_CTRL_ERR_PAUSE_ENA             0x0002

#define ADSP2_CTRL_ERR_EINT                  0x0001
@@ -4364,9 +4364,9 @@ irqreturn_t wm_adsp2_bus_error(int irq, void *data) 
		wm_adsp_fatal_error(dsp);

	}



	if (val & (ADSP2_SLAVE_ERR_MASK | ADSP2_REGION_LOCK_ERR_MASK)) {

		if (val & ADSP2_SLAVE_ERR_MASK)

			adsp_err(dsp, "bus error: slave error\n");

	if (val & (ADSP2_ADDR_ERR_MASK | ADSP2_REGION_LOCK_ERR_MASK)) {

		if (val & ADSP2_ADDR_ERR_MASK)

			adsp_err(dsp, "bus error: address error\n");

		else

			adsp_err(dsp, "bus error: region lock error\n");