Commit a4d22e33 authored by Bob Peterson's avatar Bob Peterson Committed by Andreas Gruenbacher
Browse files

gfs2: move qdsb_put and reduce redundancy 



This patch looks more invasive than it is. It simply moves function
qdsb_put before qd_unlock, then changes qd_unlock to call it rather than
open coding it. Again, this reduces redundancy.

Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent 03d468f1

fs/gfs2/quota.c

+8 −10
Original line number Diff line number Diff line
@@ -509,15 +509,20 @@ static int qd_fish(struct gfs2_sbd *sdp, struct gfs2_quota_data **qdp) 
	return 0;

}



static void qd_unlock(struct gfs2_quota_data *qd)

static void qdsb_put(struct gfs2_quota_data *qd)

{

	gfs2_assert_warn(qd->qd_sbd, test_bit(QDF_LOCKED, &qd->qd_flags));

	clear_bit(QDF_LOCKED, &qd->qd_flags);

	bh_put(qd);

	slot_put(qd);

	qd_put(qd);

}



static void qd_unlock(struct gfs2_quota_data *qd)

{

	gfs2_assert_warn(qd->qd_sbd, test_bit(QDF_LOCKED, &qd->qd_flags));

	clear_bit(QDF_LOCKED, &qd->qd_flags);

	qdsb_put(qd);

}



static int qdsb_get(struct gfs2_sbd *sdp, struct kqid qid,

		    struct gfs2_quota_data **qdp)

{
@@ -544,13 +549,6 @@ static int qdsb_get(struct gfs2_sbd *sdp, struct kqid qid, 
	return error;

}



static void qdsb_put(struct gfs2_quota_data *qd)

{

	bh_put(qd);

	slot_put(qd);

	qd_put(qd);

}



/**

 * gfs2_qa_get - make sure we have a quota allocations data structure,

 *               if necessary