Commit a4ca033d authored by Dan Carpenter's avatar Dan Carpenter Committed by Herbert Xu
Browse files

crypto: ixp4xx - silence uninitialized variable warning 



Smatch complains that "dma" is uninitialized if dma_pool_alloc() fails.
This is true, but also harmless.  Anyway, move the assignment after the
error checking to silence this warning.

Fixes: 586d492f ("crypto: ixp4xx - fix building wiht 64-bit dma_addr_t")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarArnd Bergmann <arnd@arndb.de>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 3e522591

drivers/crypto/intel/ixp4xx/ixp4xx_crypto.c

+1 −1
Original line number Diff line number Diff line
@@ -1175,9 +1175,9 @@ static int aead_perform(struct aead_request *req, int encrypt, 
		/* The 12 hmac bytes are scattered,

		 * we need to copy them into a safe buffer */

		req_ctx->hmac_virt = dma_pool_alloc(buffer_pool, flags, &dma);

		crypt->icv_rev_aes = dma;

		if (unlikely(!req_ctx->hmac_virt))

			goto free_buf_dst;

		crypt->icv_rev_aes = dma;

		if (!encrypt) {

			scatterwalk_map_and_copy(req_ctx->hmac_virt,

						 req->src, cryptlen, authsize, 0);