Commit a4c55e16 authored by Vishakha Channapattan's avatar Vishakha Channapattan Committed by Martin K. Petersen
Browse files

scsi: pm80xx: Add sysfs attribute to check controller hmi error 

A new sysfs variable 'ctl_hmi_error' is being introduced to give the error
details if the MPI initialization fails

Using the 'ctl_hmi_error' sysfs variable we can check the error details:

    linux-2dq0:~# cat /sys/class/scsi_host/host*/ctl_hmi_error
    0x00000000
    0x00000000
    0x00000000

Link: https://lore.kernel.org/r/20210415103352.3580-3-Viswas.G@microchip.com


Signed-off-by: default avatarVishakha Channapattan <vishakhavc@google.com>
Signed-off-by: default avatarViswas G <Viswas.G@microchip.com>
Signed-off-by: default avatarRuksar Devadi <Ruksar.devadi@microchip.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 4ddbea1b

drivers/scsi/pm8001/pm8001_ctl.c

+22 −0
Original line number Diff line number Diff line
@@ -911,6 +911,27 @@ static ssize_t ctl_mpi_state_show(struct device *cdev, 
}

static DEVICE_ATTR_RO(ctl_mpi_state);



/**

 * ctl_hmi_error_show - controller MPI initialization fails

 * @cdev: pointer to embedded class device

 * @buf: the buffer returned

 *

 * A sysfs 'read-only' shost attribute.

 */



static ssize_t ctl_hmi_error_show(struct device *cdev,

		struct device_attribute *attr, char *buf)

{

	struct Scsi_Host *shost = class_to_shost(cdev);

	struct sas_ha_struct *sha = SHOST_TO_SAS_HA(shost);

	struct pm8001_hba_info *pm8001_ha = sha->lldd_ha;

	unsigned int mpidw0;



	mpidw0 = pm8001_mr32(pm8001_ha->general_stat_tbl_addr, 0);

	return sysfs_emit(buf, "0x%08x\n", (mpidw0 >> 16));

}

static DEVICE_ATTR_RO(ctl_hmi_error);



struct device_attribute *pm8001_host_attrs[] = {

	&dev_attr_interface_rev,

	&dev_attr_controller_fatal_error,
@@ -935,6 +956,7 @@ struct device_attribute *pm8001_host_attrs[] = { 
	&dev_attr_ila_version,

	&dev_attr_inc_fw_ver,

	&dev_attr_ctl_mpi_state,

	&dev_attr_ctl_hmi_error,

	NULL,

};