Commit a4b58f17 authored by Jens Axboe's avatar Jens Axboe
Browse files

Merge tag 'nvme-5.13-2021-05-27' of git://git.infradead.org/nvme into block-5.13 

Pull NVMe fixes from Christoph:

"nvme fixes for Linux 5.13

 - fix a memory leak in nvme_cdev_add (Guoqing Jiang)
 - fix inline data size comparison in nvmet_tcp_queue_response (Hou Pu)
 - fix false keep-alive timeout when a controller is torn down
   (Sagi Grimberg)
 - fix a nvme-tcp Kconfig dependency (Sagi Grimberg)
 - short-circuit reconnect retries for FC (Hannes Reinecke)
 - decode host pathing error for connect (Hannes Reinecke)"

* tag 'nvme-5.13-2021-05-27' of git://git.infradead.org/nvme:
  nvmet: fix false keep-alive timeout when a controller is torn down
  nvmet-tcp: fix inline data size comparison in nvmet_tcp_queue_response
  nvme-tcp: remove incorrect Kconfig dep in BLK_DEV_NVME
  nvme-fabrics: decode host pathing error for connect
  nvme-fc: short-circuit reconnect retries
  nvme: fix potential memory leaks in nvme_cdev_add
parents 094c271a aaeadd70

drivers/nvme/host/Kconfig

+2 −1
Original line number Diff line number Diff line
@@ -71,7 +71,8 @@ config NVME_FC 
config NVME_TCP

	tristate "NVM Express over Fabrics TCP host driver"

	depends on INET

	depends on BLK_DEV_NVME

	depends on BLOCK

	select NVME_CORE

	select NVME_FABRICS

	select CRYPTO

	select CRYPTO_CRC32C

drivers/nvme/host/core.c

+3 −1
Original line number Diff line number Diff line
@@ -3485,8 +3485,10 @@ int nvme_cdev_add(struct cdev *cdev, struct device *cdev_device, 
	cdev_init(cdev, fops);

	cdev->owner = owner;

	ret = cdev_device_add(cdev, cdev_device);

	if (ret)

	if (ret) {

		put_device(cdev_device);

		ida_simple_remove(&nvme_ns_chr_minor_ida, minor);

	}

	return ret;

}

drivers/nvme/host/fabrics.c

+5 −0
Original line number Diff line number Diff line
@@ -336,6 +336,11 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl, 
			cmd->connect.recfmt);

		break;



	case NVME_SC_HOST_PATH_ERROR:

		dev_err(ctrl->device,

			"Connect command failed: host path error\n");

		break;



	default:

		dev_err(ctrl->device,

			"Connect command failed, error wo/DNR bit: %d\n",

drivers/nvme/host/fc.c

+17 −8
Original line number Diff line number Diff line
@@ -3107,6 +3107,7 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl) 
	if (ctrl->ctrl.icdoff) {

		dev_err(ctrl->ctrl.device, "icdoff %d is not supported!\n",

				ctrl->ctrl.icdoff);

		ret = NVME_SC_INVALID_FIELD | NVME_SC_DNR;

		goto out_disconnect_admin_queue;

	}
@@ -3114,6 +3115,7 @@ nvme_fc_create_association(struct nvme_fc_ctrl *ctrl) 
	if (!(ctrl->ctrl.sgls & ((1 << 0) | (1 << 1)))) {

		dev_err(ctrl->ctrl.device,

			"Mandatory sgls are not supported!\n");

		ret = NVME_SC_INVALID_FIELD | NVME_SC_DNR;

		goto out_disconnect_admin_queue;

	}
@@ -3280,11 +3282,13 @@ nvme_fc_reconnect_or_delete(struct nvme_fc_ctrl *ctrl, int status) 
	if (ctrl->ctrl.state != NVME_CTRL_CONNECTING)

		return;



	if (portptr->port_state == FC_OBJSTATE_ONLINE)

	if (portptr->port_state == FC_OBJSTATE_ONLINE) {

		dev_info(ctrl->ctrl.device,

			"NVME-FC{%d}: reset: Reconnect attempt failed (%d)\n",

			ctrl->cnum, status);

	else if (time_after_eq(jiffies, rport->dev_loss_end))

		if (status > 0 && (status & NVME_SC_DNR))

			recon = false;

	} else if (time_after_eq(jiffies, rport->dev_loss_end))

		recon = false;



	if (recon && nvmf_should_reconnect(&ctrl->ctrl)) {
@@ -3298,12 +3302,17 @@ nvme_fc_reconnect_or_delete(struct nvme_fc_ctrl *ctrl, int status) 


		queue_delayed_work(nvme_wq, &ctrl->connect_work, recon_delay);

	} else {

		if (portptr->port_state == FC_OBJSTATE_ONLINE)

		if (portptr->port_state == FC_OBJSTATE_ONLINE) {

			if (status > 0 && (status & NVME_SC_DNR))

				dev_warn(ctrl->ctrl.device,

				"NVME-FC{%d}: Max reconnect attempts (%d) "

				"reached.\n",

				ctrl->cnum, ctrl->ctrl.nr_reconnects);

					 "NVME-FC{%d}: reconnect failure\n",

					 ctrl->cnum);

			else

				dev_warn(ctrl->ctrl.device,

					 "NVME-FC{%d}: Max reconnect attempts "

					 "(%d) reached.\n",

					 ctrl->cnum, ctrl->ctrl.nr_reconnects);

		} else

			dev_warn(ctrl->ctrl.device,

				"NVME-FC{%d}: dev_loss_tmo (%d) expired "

				"while waiting for remoteport connectivity.\n",

drivers/nvme/target/core.c

+11 −4
Original line number Diff line number Diff line
@@ -388,10 +388,10 @@ static void nvmet_keep_alive_timer(struct work_struct *work) 
{

	struct nvmet_ctrl *ctrl = container_of(to_delayed_work(work),

			struct nvmet_ctrl, ka_work);

	bool cmd_seen = ctrl->cmd_seen;

	bool reset_tbkas = ctrl->reset_tbkas;



	ctrl->cmd_seen = false;

	if (cmd_seen) {

	ctrl->reset_tbkas = false;

	if (reset_tbkas) {

		pr_debug("ctrl %d reschedule traffic based keep-alive timer\n",

			ctrl->cntlid);

		schedule_delayed_work(&ctrl->ka_work, ctrl->kato * HZ);
@@ -804,6 +804,13 @@ void nvmet_sq_destroy(struct nvmet_sq *sq) 
	percpu_ref_exit(&sq->ref);



	if (ctrl) {

		/*

		 * The teardown flow may take some time, and the host may not

		 * send us keep-alive during this period, hence reset the

		 * traffic based keep-alive timer so we don't trigger a

		 * controller teardown as a result of a keep-alive expiration.

		 */

		ctrl->reset_tbkas = true;

		nvmet_ctrl_put(ctrl);

		sq->ctrl = NULL; /* allows reusing the queue later */

	}
@@ -952,7 +959,7 @@ bool nvmet_req_init(struct nvmet_req *req, struct nvmet_cq *cq, 
	}



	if (sq->ctrl)

		sq->ctrl->cmd_seen = true;

		sq->ctrl->reset_tbkas = true;



	return true;