Commit a4a79e03 authored by Tony Lindgren's avatar Tony Lindgren Committed by Greg Kroah-Hartman
Browse files

serial: core: Revert port_id use 



Guenter reports boot issues with duplicate sysfs entries for multiport
drivers. Let's go back to using port->line for now to fix the regression.

With this change, the serial core port device names are not correct for the
hardware specific 8250 single port drivers, but that's a cosmetic issue for
now.

Fixes: d962de6a ("serial: core: Fix serial core port id to not use port->line")
Reported-by: default avatarGuenter Roeck <groeck7@gmail.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230806062052.47737-1-tony@atomide.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3f29d9ee

drivers/tty/serial/serial_base_bus.c

+1 −1
Original line number Diff line number Diff line
@@ -151,7 +151,7 @@ struct serial_port_device *serial_base_port_add(struct uart_port *port, 
	err = serial_base_device_init(port, &port_dev->dev,

				      &ctrl_dev->dev, &serial_port_type,

				      serial_base_port_release,

				      port->ctrl_id, port->port_id);

				      port->ctrl_id, port->line);

	if (err)

		goto err_put_device;