Unverified Commit a4359b4e authored Apr 25, 2022 by Uwe Kleine-König Committed by Javier Martinez Canillas Apr 26, 2022

drm/ssd130x: Make ssd130x_remove() return void

This function returns zero unconditionally, so there isn't any benefit
of returning a value. Make it return void to be able to see at a glance
that the return value of ssd130x_i2c_remove() is always zero.

This patch is a preparation for making i2c remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220425192306.59800-1-u.kleine-koenig@pengutronix.de

parent 57e6f056

drivers/gpu/drm/solomon/ssd130x-i2c.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -43,7 +43,9 @@ static int ssd130x_i2c_remove(struct i2c_client *client)
	{		{
	struct ssd130x_device *ssd130x = i2c_get_clientdata(client);		struct ssd130x_device *ssd130x = i2c_get_clientdata(client);

	return ssd130x_remove(ssd130x);		ssd130x_remove(ssd130x);

			return 0;
	}		}

	static void ssd130x_i2c_shutdown(struct i2c_client *client)		static void ssd130x_i2c_shutdown(struct i2c_client *client)

drivers/gpu/drm/solomon/ssd130x.c

+1 −3

Original line number	Original line	Diff line number	Diff line
	@@ -924,11 +924,9 @@ struct ssd130x_device ssd130x_probe(struct device dev, struct regmap *regmap)
	}		}
	EXPORT_SYMBOL_GPL(ssd130x_probe);		EXPORT_SYMBOL_GPL(ssd130x_probe);

	int ssd130x_remove(struct ssd130x_device *ssd130x)		void ssd130x_remove(struct ssd130x_device *ssd130x)
	{		{
	drm_dev_unplug(&ssd130x->drm);		drm_dev_unplug(&ssd130x->drm);

	return 0;
	}		}
	EXPORT_SYMBOL_GPL(ssd130x_remove);		EXPORT_SYMBOL_GPL(ssd130x_remove);

drivers/gpu/drm/solomon/ssd130x.h

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -86,7 +86,7 @@ struct ssd130x_device {
	extern const struct ssd130x_deviceinfo ssd130x_variants[];		extern const struct ssd130x_deviceinfo ssd130x_variants[];

	struct ssd130x_device ssd130x_probe(struct device dev, struct regmap *regmap);		struct ssd130x_device ssd130x_probe(struct device dev, struct regmap *regmap);
	int ssd130x_remove(struct ssd130x_device *ssd130x);		void ssd130x_remove(struct ssd130x_device *ssd130x);
	void ssd130x_shutdown(struct ssd130x_device *ssd130x);		void ssd130x_shutdown(struct ssd130x_device *ssd130x);

	#endif /* __SSD1307X_H__ */		#endif /* __SSD1307X_H__ */