Commit a3e5e579 authored by Dmytro Linkin's avatar Dmytro Linkin Committed by David S. Miller
Browse files

devlink: Protect rate list with lock while switching modes 



Devlink eswitch set command doesn't hold devlink->lock, which makes
possible race condition between rate list traversing and others devlink
rate KAPI calls, like devlink_rate_nodes_destroy().
Hold devlink lock while traversing the list.

Fixes: a8ecb93e ("devlink: Introduce rate nodes")
Signed-off-by: default avatarDmytro Linkin <dlinkin@nvidia.com>
Reviewed-by: default avatarParav Pandit <parav@nvidia.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ff99324d

net/core/devlink.c

+4 −0
Original line number Diff line number Diff line
@@ -2710,11 +2710,15 @@ static int devlink_rate_nodes_check(struct devlink *devlink, u16 mode, 
{

	struct devlink_rate *devlink_rate;



	/* Take the lock to sync with devlink_rate_nodes_destroy() */

	mutex_lock(&devlink->lock);

	list_for_each_entry(devlink_rate, &devlink->rate_list, list)

		if (devlink_rate_is_node(devlink_rate)) {

			mutex_unlock(&devlink->lock);

			NL_SET_ERR_MSG_MOD(extack, "Rate node(s) exists.");

			return -EBUSY;

		}

	mutex_unlock(&devlink->lock);

	return 0;

}