Commit a3e340c1 authored by Dave Jiang's avatar Dave Jiang Committed by Vinod Koul
Browse files

dmaengine: idxd: fix resource leak on dmaengine driver disable 



The wq resources needs to be released before the kernel type is reset by
__drv_disable_wq(). With dma channels unregistered and wq quiesced, all the
wq resources for dmaengine can be freed. There is no need to wait until wq
is disabled. With the wq->type being reset to "unknown", the driver is
skipping the freeing of the resources.

Fixes: 0cda4f69 ("dmaengine: idxd: create dmaengine driver for wq 'device'")
Reported-by: default avatarJacob Pan <jacob.jun.pan@linux.intel.com>
Tested-by: default avatarJacob Pan <jacob.jun.pan@linux.intel.com>
Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/163517405099.3484556.12521975053711345244.stgit@djiang5-desk3.ch.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 2efe58cf

drivers/dma/idxd/dma.c

+1 −2
Original line number Diff line number Diff line
@@ -329,10 +329,9 @@ static void idxd_dmaengine_drv_remove(struct idxd_dev *idxd_dev) 
	mutex_lock(&wq->wq_lock);

	idxd_wq_quiesce(wq);

	idxd_unregister_dma_channel(wq);

	idxd_wq_free_resources(wq);

	__drv_disable_wq(wq);

	percpu_ref_exit(&wq->wq_active);

	idxd_wq_free_resources(wq);

	wq->type = IDXD_WQT_NONE;

	mutex_unlock(&wq->wq_lock);

}