Commit a3afbf5c authored by Badhri Jagan Sridharan's avatar Badhri Jagan Sridharan Committed by Greg Kroah-Hartman
Browse files

usb: gadget: udc: core: Prevent redundant calls to pullup 



usb_gadget_connect calls gadget->ops->pullup without checking whether
gadget->connected was previously set. Make this symmetric to
usb_gadget_disconnect by returning early if gadget->connected is
already set.

Fixes: 5a1da544 ("usb: gadget: core: do not try to disconnect gadget if it is not connected")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarBadhri Jagan Sridharan <badhri@google.com>
Link: https://lore.kernel.org/r/20230407030741.3163220-2-badhri@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0db213ea

drivers/usb/gadget/udc/core.c

+3 −0
Original line number Diff line number Diff line
@@ -703,6 +703,9 @@ static int usb_gadget_connect_locked(struct usb_gadget *gadget) 
		goto out;

	}



	if (gadget->connected)

		goto out;



	if (gadget->deactivated || !gadget->udc->started) {

		/*

		 * If gadget is deactivated we only save new state.