Commit a3ae9959 authored by Lyude Paul's avatar Lyude Paul Committed by Alex Deucher
Browse files

drm/display/dp_mst: Fix drm_dp_mst_add_affected_dsc_crtcs() return code 



Looks like that we're accidentally dropping a pretty important return code
here. For some reason, we just return -EINVAL if we fail to get the MST
topology state. This is wrong: error codes are important and should never
be squashed without being handled, which here seems to have the potential
to cause a deadlock.

Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
Reviewed-by: default avatarWayne Lin <Wayne.Lin@amd.com>
Fixes: 8ec04671 ("drm/dp_mst: Add helper to trigger modeset on affected DSC MST CRTCs")
Cc: <stable@vger.kernel.org> # v5.6+
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 7cce4cd6

drivers/gpu/drm/display/drm_dp_mst_topology.c

+1 −1
Original line number Diff line number Diff line
@@ -5186,7 +5186,7 @@ int drm_dp_mst_add_affected_dsc_crtcs(struct drm_atomic_state *state, struct drm 
	mst_state = drm_atomic_get_mst_topology_state(state, mgr);



	if (IS_ERR(mst_state))

		return -EINVAL;

		return PTR_ERR(mst_state);



	list_for_each_entry(pos, &mst_state->payloads, next) {