Commit a344a1e8 authored by Andrew Lunn's avatar Andrew Lunn Committed by Jakub Kicinski
Browse files

drivers: net: wan: lmc: Fix W=1 set but used variable warnings 



drivers/net/wan/lmc/lmc_main.c: In function ‘lmc_ioctl’:
drivers/net/wan/lmc/lmc_main.c:356:25: warning: variable ‘mii’ set but not used [-Wunused-but-set-variable]
  356 |                     u16 mii;
      |                         ^~~
drivers/net/wan/lmc/lmc_main.c:427:25: warning: variable ‘mii’ set but not used [-Wunused-but-set-variable]
  427 |                     u16 mii;
      |                         ^~~
drivers/net/wan/lmc/lmc_main.c: In function ‘lmc_interrupt’:
drivers/net/wan/lmc/lmc_main.c:1188:9: warning: variable ‘firstcsr’ set but not used [-Wunused-but-set-variable]
 1188 |     u32 firstcsr;

This file has funky indentation, and makes little use of tabs. Keep
with this style in the patch, but that makes checkpatch unhappy.

Signed-off-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20201031181417.1081511-1-andrew@lunn.ch


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8ed7ec13

drivers/net/wan/lmc/lmc_main.c

+2 −7
Original line number Diff line number Diff line
@@ -353,9 +353,8 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/ 
            switch(xc.command){

            case lmc_xilinx_reset: /*fold02*/

                {

                    u16 mii;

		    spin_lock_irqsave(&sc->lmc_lock, flags);

                    mii = lmc_mii_readreg (sc, 0, 16);

                    lmc_mii_readreg (sc, 0, 16);



                    /*

                     * Make all of them 0 and make input
@@ -424,10 +423,9 @@ int lmc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/ 
                break;

            case lmc_xilinx_load_prom: /*fold02*/

                {

                    u16 mii;

                    int timeout = 500000;

		    spin_lock_irqsave(&sc->lmc_lock, flags);

                    mii = lmc_mii_readreg (sc, 0, 16);

                    lmc_mii_readreg (sc, 0, 16);



                    /*

                     * Make all of them 0 and make input
@@ -1185,7 +1183,6 @@ static irqreturn_t lmc_interrupt (int irq, void *dev_instance) /*fold00*/ 
    int i;

    s32 stat;

    unsigned int badtx;

    u32 firstcsr;

    int max_work = LMC_RXDESCS;

    int handled = 0;
@@ -1203,8 +1200,6 @@ static irqreturn_t lmc_interrupt (int irq, void *dev_instance) /*fold00*/ 
        goto lmc_int_fail_out;

    }



    firstcsr = csr;



    /* always go through this loop at least once */

    while (csr & sc->lmc_intrmask) {

	handled = 1;