Commit a33e5e39 authored by Basavaraj Natikar's avatar Basavaraj Natikar Committed by Jiri Kosina
Browse files

HID: amd_sfh: Fix illuminance value 



Illuminance value is actually 32 bits, but is incorrectly trancated to
16 bits. Hence convert to integer illuminace accordingly to reflect
correct values.

Fixes: 93ce5e02 ("HID: amd_sfh: Implement SFH1.1 functionality")
Signed-off-by: default avatarBasavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 0b9255bf

drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c

+1 −1
Original line number Diff line number Diff line
@@ -218,7 +218,7 @@ static u8 get_input_rep(u8 current_index, int sensor_idx, int report_id, 
			     OFFSET_SENSOR_DATA_DEFAULT;

		memcpy_fromio(&als_data, sensoraddr, sizeof(struct sfh_als_data));

		get_common_inputs(&als_input.common_property, report_id);

		als_input.illuminance_value = als_data.lux;

		als_input.illuminance_value = float_to_int(als_data.lux);

		report_size = sizeof(als_input);

		memcpy(input_report, &als_input, sizeof(als_input));

		break;

drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_interface.h

+1 −1
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ struct sfh_mag_data { 


struct sfh_als_data {

	struct sfh_common_data commondata;

	u16 lux;

	u32 lux;

};



struct hpd_status {