Unverified Commit a336dc8f authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

regulator: da9052: Ensure enough delay time for .set_voltage_time_sel 



Use DIV_ROUND_UP to prevent truncation by integer division issue.
This ensures we return enough delay time.

Also fix returning negative value when new_sel < old_sel.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Link: https://lore.kernel.org/r/20210618141412.4014912-1-axel.lin@ingics.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 9bc146ac

drivers/regulator/da9052-regulator.c

+2 −1
Original line number Diff line number Diff line
@@ -250,7 +250,8 @@ static int da9052_regulator_set_voltage_time_sel(struct regulator_dev *rdev, 
	case DA9052_ID_BUCK3:

	case DA9052_ID_LDO2:

	case DA9052_ID_LDO3:

		ret = (new_sel - old_sel) * info->step_uV / 6250;

		ret = DIV_ROUND_UP(abs(new_sel - old_sel) * info->step_uV,

				   6250);

		break;

	}