Commit a3170376 authored by Stanley Chu's avatar Stanley Chu Committed by Martin K. Petersen
Browse files

scsi: ufs: Simplify completion timestamp for SCSI and query commands 

Simplify recording command completion time in __ufshcd_transfer_req_compl()
by assigning lrbp->compl_time_stamp in a unified location.

Link: https://lore.kernel.org/r/20200706060707.32608-2-stanley.chu@mediatek.com


Acked-by: default avatarAvri Altman <Avri.Altman@wdc.com>
Signed-off-by: default avatarStanley Chu <stanley.chu@mediatek.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent b53293fa

drivers/scsi/ufs/ufshcd.c

+1 −2
Original line number Diff line number Diff line
@@ -4910,6 +4910,7 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba, 


	for_each_set_bit(index, &completed_reqs, hba->nutrs) {

		lrbp = &hba->lrb[index];

		lrbp->compl_time_stamp = ktime_get();

		cmd = lrbp->cmd;

		if (cmd) {

			ufshcd_add_command_trace(hba, index, "complete");
@@ -4918,13 +4919,11 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba, 
			cmd->result = result;

			/* Mark completed command as NULL in LRB */

			lrbp->cmd = NULL;

			lrbp->compl_time_stamp = ktime_get();

			/* Do not touch lrbp after scsi done */

			cmd->scsi_done(cmd);

			__ufshcd_release(hba);

		} else if (lrbp->command_type == UTP_CMD_TYPE_DEV_MANAGE ||

			lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {

			lrbp->compl_time_stamp = ktime_get();

			if (hba->dev_cmd.complete) {

				ufshcd_add_command_trace(hba, index,

						"dev_complete");