Commit a30a2909 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Linus Torvalds
Browse files

mm/mremap: fix BUILD_BUG_ON() error in get_extent 

clang can't evaluate this function argument at compile time when the
function is not inlined, which leads to a link time failure:

  ld.lld: error: undefined symbol: __compiletime_assert_414
  >>> referenced by mremap.c
  >>>               mremap.o:(get_extent) in archive mm/built-in.a

Mark the function as __always_inline to avoid it.

Link: https://lkml.kernel.org/r/20201230154104.522605-1-arnd@kernel.org


Fixes: 9ad9718b ("mm/mremap: calculate extent in one place")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Tested-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Reviewed-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Tested-by: default avatarSedat Dilek <sedat.dilek@gmail.com>
Cc: Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Dmitry Safonov <0x7f454c46@gmail.com>
Cc: Brian Geffon <bgeffon@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 793f49a8

mm/mremap.c

+3 −2
Original line number Diff line number Diff line
@@ -336,8 +336,9 @@ enum pgt_entry { 
 * valid. Else returns a smaller extent bounded by the end of the source and

 * destination pgt_entry.

 */

static unsigned long get_extent(enum pgt_entry entry, unsigned long old_addr,

			unsigned long old_end, unsigned long new_addr)

static __always_inline unsigned long get_extent(enum pgt_entry entry,

			unsigned long old_addr, unsigned long old_end,

			unsigned long new_addr)

{

	unsigned long next, extent, mask, size;