Commit a306aba9 authored by Dinghao Liu's avatar Dinghao Liu Committed by Jason Gunthorpe
Browse files

RDMA/usnic: Fix memleak in find_free_vf_and_create_qp_grp 

If usnic_ib_qp_grp_create() fails at the first call, dev_list
will not be freed on error, which leads to memleak.

Fixes: e3cf00d0 ("IB/usnic: Add Cisco VIC low-level hardware driver")
Link: https://lore.kernel.org/r/20201226074248.2893-1-dinghao.liu@zju.edu.cn


Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 3c638cdb

drivers/infiniband/hw/usnic/usnic_ib_verbs.c

+3 −0
Original line number Diff line number Diff line
@@ -214,6 +214,7 @@ find_free_vf_and_create_qp_grp(struct usnic_ib_dev *us_ibdev, 


		}

		usnic_uiom_free_dev_list(dev_list);

		dev_list = NULL;

	}



	/* Try to find resources on an unused vf */
@@ -239,6 +240,8 @@ find_free_vf_and_create_qp_grp(struct usnic_ib_dev *us_ibdev, 
qp_grp_check:

	if (IS_ERR_OR_NULL(qp_grp)) {

		usnic_err("Failed to allocate qp_grp\n");

		if (usnic_ib_share_vf)

			usnic_uiom_free_dev_list(dev_list);

		return ERR_PTR(qp_grp ? PTR_ERR(qp_grp) : -ENOMEM);

	}

	return qp_grp;