Commit a2fb4983 authored by Masami Hiramatsu's avatar Masami Hiramatsu Committed by Alexei Starovoitov
Browse files

rethook: Fix to use WRITE_ONCE() for rethook:: Handler 



Since the function pointered by rethook::handler never be removed when
the rethook is alive, it doesn't need to use rcu_assign_pointer() to
update it. Just use WRITE_ONCE().

Reported-by: default avatarAlexei Starovoitov <alexei.starovoitov@gmail.com>
Signed-off-by: default avatarMasami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/164868907688.21983.1606862921419988152.stgit@devnote2
parent 2609f635

kernel/trace/rethook.c

+1 −1
Original line number Diff line number Diff line
@@ -65,7 +65,7 @@ static void rethook_free_rcu(struct rcu_head *head) 
 */

void rethook_free(struct rethook *rh)

{

	rcu_assign_pointer(rh->handler, NULL);

	WRITE_ONCE(rh->handler, NULL);



	call_rcu(&rh->rcu, rethook_free_rcu);

}