Commit a2f7a0bf authored by Wei Yang's avatar Wei Yang Committed by Ingo Molnar
Browse files

x86/mm: Fix function name typo in pmd_read_atomic() comment 



The function involved should be pte_offset_map_lock() and we never have
function pmd_offset_map_lock defined.

Signed-off-by: default avatarWei Yang <richardw.yang@linux.intel.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@surriel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190925014453.20236-1-richardw.yang@linux.intel.com


[ Minor edits. ]
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 77df779d

arch/x86/include/asm/pgtable-3level.h

+2 −2
Original line number Original line Diff line number Diff line
@@ -44,10 +44,10 @@ static inline void native_set_pte(pte_t *ptep, pte_t pte) 
 * pmd_populate rightfully does a set_64bit, but if we're reading the

 * pmd_populate rightfully does a set_64bit, but if we're reading the

 * pmd_t with a "*pmdp" on the mincore side, a SMP race can happen

 * pmd_t with a "*pmdp" on the mincore side, a SMP race can happen

 * because gcc will not read the 64bit of the pmd atomically. To fix

 * because gcc will not read the 64bit of the pmd atomically. To fix

 * this all places running pmd_offset_map_lock() while holding the

 * this all places running pte_offset_map_lock() while holding the

 * mmap_sem in read mode, shall read the pmdp pointer using this

 * mmap_sem in read mode, shall read the pmdp pointer using this

 * function to know if the pmd is null nor not, and in turn to know if

 * function to know if the pmd is null nor not, and in turn to know if

 * they can run pmd_offset_map_lock or pmd_trans_huge or other pmd

 * they can run pte_offset_map_lock() or pmd_trans_huge() or other pmd

 * operations.

 * operations.

 *

 *

 * Without THP if the mmap_sem is hold for reading, the pmd can only

 * Without THP if the mmap_sem is hold for reading, the pmd can only