Commit a2dd9bd9 authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Jonathan Cameron
Browse files

iio: imu: st_lsm6dsx: check return value from st_lsm6dsx_sensor_set_enable 



Add missing return value check in st_lsm6dsx_read_oneshot disabling the
sensor. The issue is reported by coverity with the following error:

Unchecked return value:
If the function returns an error value, the error value may be mistaken
for a normal value.

Addresses-Coverity-ID: 1446733 ("Unchecked return value")
Fixes: b5969abf ("iio: imu: st_lsm6dsx: add motion events")
Fixes: 290a6ce1 ("iio: imu: add support to lsm6dsx driver")
Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 4766897a

drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c

+5 −2
Original line number Diff line number Diff line
@@ -1555,8 +1555,11 @@ static int st_lsm6dsx_read_oneshot(struct st_lsm6dsx_sensor *sensor, 
	if (err < 0)

		return err;



	if (!hw->enable_event)

		st_lsm6dsx_sensor_set_enable(sensor, false);

	if (!hw->enable_event) {

		err = st_lsm6dsx_sensor_set_enable(sensor, false);

		if (err < 0)

			return err;

	}



	*val = (s16)le16_to_cpu(data);