Commit a2d40ce7 authored by Xu Panda's avatar Xu Panda Committed by David S. Miller
Browse files

myri10ge: use strscpy() to instead of strncpy() 



The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.

Signed-off-by: default avatarXu Panda <xu.panda@zte.com.cn>
Signed-off-by: default avatarYang Yang <yang.yang29@zte.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f6b759f5

drivers/net/ethernet/myricom/myri10ge/myri10ge.c

+1 −2
Original line number Diff line number Diff line
@@ -552,8 +552,7 @@ myri10ge_validate_firmware(struct myri10ge_priv *mgp, 
	}



	/* save firmware version for ethtool */

	strncpy(mgp->fw_version, hdr->version, sizeof(mgp->fw_version));

	mgp->fw_version[sizeof(mgp->fw_version) - 1] = '\0';

	strscpy(mgp->fw_version, hdr->version, sizeof(mgp->fw_version));



	sscanf(mgp->fw_version, "%d.%d.%d", &mgp->fw_ver_major,

	       &mgp->fw_ver_minor, &mgp->fw_ver_tiny);