Commit a2d33b5d authored by Matthew Wilcox (Oracle)'s avatar Matthew Wilcox (Oracle) Committed by Andrew Morton
Browse files

mm/swap: optimise lru_add_drain_cpu() 

Do the per-cpu dereferencing of the fbatches once which saves 14 bytes
of text and several percpu relocations.

Link: https://lkml.kernel.org/r/20220617175020.717127-12-willy@infradead.org


Signed-off-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 4864545a

mm/swap.c

+5 −4
Original line number Diff line number Diff line
@@ -620,7 +620,8 @@ static void lru_lazyfree_fn(struct lruvec *lruvec, struct folio *folio) 
 */

void lru_add_drain_cpu(int cpu)

{

	struct folio_batch *fbatch = &per_cpu(cpu_fbatches.lru_add, cpu);

	struct cpu_fbatches *fbatches = &per_cpu(cpu_fbatches, cpu);

	struct folio_batch *fbatch = &fbatches->lru_add;



	if (folio_batch_count(fbatch))

		folio_batch_move_lru(fbatch, lru_add_fn);
@@ -636,15 +637,15 @@ void lru_add_drain_cpu(int cpu) 
		local_unlock_irqrestore(&lru_rotate.lock, flags);

	}



	fbatch = &per_cpu(cpu_fbatches.lru_deactivate_file, cpu);

	fbatch = &fbatches->lru_deactivate_file;

	if (folio_batch_count(fbatch))

		folio_batch_move_lru(fbatch, lru_deactivate_file_fn);



	fbatch = &per_cpu(cpu_fbatches.lru_deactivate, cpu);

	fbatch = &fbatches->lru_deactivate;

	if (folio_batch_count(fbatch))

		folio_batch_move_lru(fbatch, lru_deactivate_fn);



	fbatch = &per_cpu(cpu_fbatches.lru_lazyfree, cpu);

	fbatch = &fbatches->lru_lazyfree;

	if (folio_batch_count(fbatch))

		folio_batch_move_lru(fbatch, lru_lazyfree_fn);